Skip to content

Conversation

@tesonep
Copy link
Collaborator

@tesonep tesonep commented Oct 31, 2025

Simplifying the implementation of MCZ format. We remove the binary serialized representation and always use the chunk one.

  • Removing all references to MCDataStream
  • Removing implementation of MCDataStream

Fix #18813

@Ducasse
Copy link
Member

Ducasse commented Nov 4, 2025

There is a conflict with the bootstrap

@Ducasse Ducasse added the Status: Need more work The issue is nearly ready. Waiting some last bits. label Nov 4, 2025
@jecisc jecisc removed the Status: Need more work The issue is nearly ready. Waiting some last bits. label Nov 5, 2025
@jecisc
Copy link
Member

jecisc commented Nov 5, 2025

image image

@jecisc
Copy link
Member

jecisc commented Nov 6, 2025

There is still a problem about Orphan packages but I don't know what is the problem checking the code changes

@jecisc
Copy link
Member

jecisc commented Nov 6, 2025

I think I know what is the problem!

The production of the .mcz is done by a Pharo 9 image (the one containing Espell). This image is generating code only with "category" and not "package" and "tag" info.

"category" is something ambiguous. And here, we have for example "Kernel-Traits" with a "Base" tag. And the StImporter is creating a package "Kernel-Traits-Base" because it is the name of the category and there is only one tag.

This will be automatically fixed when the Espell image will be updated. In the meantime, we could avoid to have packages with only 1 package tag in the first phases of the bootstrap?

This failing test could be fixed by this PR: #18842
It merges the 3 problematic packages and it loads them later in the bootstrap. It's worth trying to merge it and update this PR to see if the test is still failing.

@jecisc jecisc merged commit 50112cf into pharo-project:Pharo14 Nov 7, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Binary representation in MCZ files

3 participants