-
-
Notifications
You must be signed in to change notification settings - Fork 399
18813-Remove-Binary-representation-in-MCZ-files #18815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
18813-Remove-Binary-representation-in-MCZ-files #18815
Conversation
…rialized representation and always use the chunk one. - Removing all references to MCDataStream - Removing implementation of MCDataStream Fix pharo-project#18813
|
There is a conflict with the bootstrap |
|
There is still a problem about Orphan packages but I don't know what is the problem checking the code changes |
|
I think I know what is the problem! The production of the .mcz is done by a Pharo 9 image (the one containing Espell). This image is generating code only with "category" and not "package" and "tag" info. "category" is something ambiguous. And here, we have for example "Kernel-Traits" with a "Base" tag. And the StImporter is creating a package "Kernel-Traits-Base" because it is the name of the category and there is only one tag. This will be automatically fixed when the Espell image will be updated. In the meantime, we could avoid to have packages with only 1 package tag in the first phases of the bootstrap? This failing test could be fixed by this PR: #18842 |


Simplifying the implementation of MCZ format. We remove the binary serialized representation and always use the chunk one.
Fix #18813